🌱 Refactor dist npm script #2061
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2061 +/- ##
==========================================
+ Coverage 39.20% 42.15% +2.95%
==========================================
Files 146 174 +28
Lines 4857 5577 +720
Branches 1164 1325 +161
==========================================
+ Hits 1904 2351 +447
- Misses 2939 3210 +271
- Partials 14 16 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Change the copy package used to generate the `dist/` folder after building to use `copy-files-from-to`. The package change allows us to have a configuration file with multiple includes and excludes to make sure we copy only exactly what is needed when the `dist/` folder is built. The contents of the `dist/` folder is what is copied into the runtime container. It should be as light as possible. Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the copy package used to generate the
dist/folder after building to usecopy-files-from-to.The package change allows us to have a configuration file with multiple includes and excludes to make sure we copy only exactly what is needed when the
dist/folder is built. The contents of thedist/folder is what is copied into the runtime container. It should be as light as possible.