-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add identity form flow #2
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3677b05
to
534990b
Compare
gildub
reviewed
Feb 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Just a couple of things.
When editing a credential the values for type and below are blank, not sure if that's WIP or to be addressed by following PR.
Also see inline a comment about translation_old.json files
gildub
approved these changes
Feb 24, 2022
a569e2f
to
fad9c12
Compare
fad9c12
to
4291e32
Compare
ibolton336
added a commit
that referenced
this pull request
May 6, 2022
* Change env var names to match hub * # This is a combination of 6 commits. # This is the 1st commit message: update env var names # This is the commit message #2: add conditional for auth check message # This is the commit message #3: update error message # This is the commit message #4: Restore env var checks and pull from env var in keycloak config # This is the commit message #5: define and load env vars for consumption # This is the commit message #6: Finish adding auth required check * # This is a combination of 10 commits. # This is the 1st commit message: add conditional for auth check message update error message Restore env var checks and pull from env var in keycloak config define and load env vars for consumption Finish adding auth required check fix rbac component # This is the commit message #2: fix rbac component # This is the commit message #3: fix rbac component # This is the commit message #4: remove # This is the commit message #5: .env file instructions # This is the commit message #6: fix tests # This is the commit message #7: looking into express api served env vars # This is the commit message #8: Implement encrypted env var window object for prod # This is the commit message #9: Env var window object implementation # This is the commit message #10: Fix app crashing * Finish adding auth required check Implement encrypted env var window object for prod Use cookies for unauthenticated routes against the hub * fix * wip * cleanup * cleanup * pr comment responses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.