Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add identity form flow #2

Merged
merged 5 commits into from
Feb 24, 2022
Merged

Conversation

ibolton336
Copy link
Member

No description provided.

@ibolton336 ibolton336 force-pushed the add-identity-2 branch 6 times, most recently from 3677b05 to 534990b Compare February 23, 2022 20:36
@ibolton336 ibolton336 marked this pull request as ready for review February 23, 2022 21:00
Copy link
Contributor

@gildub gildub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Just a couple of things.
When editing a credential the values for type and below are blank, not sure if that's WIP or to be addressed by following PR.
Also see inline a comment about translation_old.json files

@ibolton336 ibolton336 force-pushed the add-identity-2 branch 2 times, most recently from a569e2f to fad9c12 Compare February 24, 2022 16:54
@ibolton336 ibolton336 merged commit cba086b into konveyor:main Feb 24, 2022
@ibolton336 ibolton336 deleted the add-identity-2 branch February 24, 2022 19:19
ibolton336 added a commit that referenced this pull request May 6, 2022
* Change env var names to match hub

* # This is a combination of 6 commits.
# This is the 1st commit message:

update env var names

# This is the commit message #2:

add conditional for auth check message

# This is the commit message #3:

update error message

# This is the commit message #4:

Restore env var checks and pull from env var in keycloak config

# This is the commit message #5:

define and load env vars for consumption

# This is the commit message #6:

Finish adding auth required check

* # This is a combination of 10 commits.
# This is the 1st commit message:

add conditional for auth check message

update error message

Restore env var checks and pull from env var in keycloak config

define and load env vars for consumption

Finish adding auth required check

fix rbac component

# This is the commit message #2:

fix rbac component

# This is the commit message #3:

fix rbac component

# This is the commit message #4:

remove

# This is the commit message #5:

.env file instructions

# This is the commit message #6:

fix tests

# This is the commit message #7:

looking into express api served env vars

# This is the commit message #8:

Implement encrypted env var window object for prod

# This is the commit message #9:

Env var window object implementation

# This is the commit message #10:

Fix app crashing

* Finish adding auth required check

Implement encrypted env var window object for prod

Use cookies for unauthenticated routes against the hub

* fix

* wip

* cleanup

* cleanup

* pr comment responses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants