🌱 Setup CI workflow to use same container as Dockerfile (#1804) #1823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![konveyor-ci-bot[bot]](https://avatars.githubusercontent.com/in/819470?s=60&v=4){kind=small}
Lookup the "FROM .* as builder" image from the project's Dockerfile, and use that image to run the CI unit-test job. This will ensure the unit-test job is using the same container image that the image builds will be using. A problem with the container should show up quickly in the unit-testing. Signed-off-by: Scott J Dickerson <sdickers@redhat.com> Signed-off-by: Cherry Picker <noreply@github.com>
sjd78
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lookup the "FROM .* as builder" image from the project's Dockerfile, and
use that image to run the CI unit-test job.
This will ensure the unit-test job is using the same container image
that the image builds will be using. A problem with the container should
show up quickly in the unit-testing.
Signed-off-by: Scott J Dickerson sdickers@redhat.com
Signed-off-by: Cherry Picker noreply@github.com