Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Handle upload state for binary upload #1467

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

ibolton336
Copy link
Member

-Set form state once the file is read in rather than when the api returns a 200 for the upload post request

Resolves https://issues.redhat.com/browse/MTA-1420

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (5cfcdbe) 40.89% compared to head (90fd452) 40.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1467      +/-   ##
==========================================
- Coverage   40.89%   40.84%   -0.06%     
==========================================
  Files         139      139              
  Lines        4450     4456       +6     
  Branches     1017     1018       +1     
==========================================
  Hits         1820     1820              
- Misses       2618     2624       +6     
  Partials       12       12              
Flag Coverage Δ
client 40.84% <0.00%> (-0.06%) ⬇️
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...tions/analysis-wizard/components/upload-binary.tsx 12.37% <0.00%> (-0.82%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant