Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Update the label for the Tag field on the Application Form #1427

Merged
merged 1 commit into from
Oct 3, 2023
Merged

🐛 Update the label for the Tag field on the Application Form #1427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions client/public/locales/en/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,7 @@
"label": "Label",
"loading": "Loading",
"lowRisk": "Low risk",
"manualTags": "Manual Tags",
"maintainers": "Maintainers",
"mavenConfig": "Maven configuration",
"mediumRisk": "Medium risk",
Expand Down
4 changes: 2 additions & 2 deletions client/src/app/pages/applications/components/application-form/application-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ export const ApplicationForm: React.FC<ApplicationFormProps> = ({

const nonManualTags = application?.tags?.filter((t) => t.source !== "") ?? [];

// TODO: Filter this if we want to exclude non-manual tags from manual tag selection
// Allow all tags to be selected manually, even if they are included from another source
const allowedManualTags = tags;

const getBinaryInitialValue = (
Expand Down Expand Up @@ -364,7 +364,7 @@ export const ApplicationForm: React.FC<ApplicationFormProps> = ({
items={allowedManualTags}
control={control}
name="tags"
label={t("terms.tags")}
label={t("terms.manualTags")}
fieldId="tags"
noResultsMessage={t("message.noResultsFoundTitle")}
placeholderText={t("composed.selectMany", {
Expand Down