Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix broken rendering of migration waves table rows, properly pass isExpandable prop in useTableControlProps #1398

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

mturley
Copy link
Collaborator

@mturley mturley commented Sep 25, 2023

In #1345, we changed the structure of the expandable rows in the Migration Waves table and caused the isExpanded prop to be present on all rows (which should only be on the expanded content rows), which caused all rows to be hidden because it was false. This PR restores the intended structure: Each row is wrapped in a <Tbody> with the isExpanded prop, which contains two <Tr>s: one for the row itself and one for the expanded content.

Also removes the cursor: "pointer" inline style on the Tbody which was causing the whole row to appear clickable even though only the expandable cells are clickable.

…sExpandable prop in useTableControlProps

Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@4ab5428). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1398   +/-   ##
=======================================
  Coverage        ?   41.34%           
=======================================
  Files           ?      138           
  Lines           ?     4334           
  Branches        ?     1039           
=======================================
  Hits            ?     1792           
  Misses          ?     2454           
  Partials        ?       88           
Flag Coverage Δ
client 41.34% <ø> (?)
server ∅ <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...c/app/hooks/table-controls/useTableControlProps.ts 13.69% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants