🐛 Fix broken rendering of migration waves table rows, properly pass isExpandable prop in useTableControlProps #1398
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1345, we changed the structure of the expandable rows in the Migration Waves table and caused the
isExpanded
prop to be present on all rows (which should only be on the expanded content rows), which caused all rows to be hidden because it was false. This PR restores the intended structure: Each row is wrapped in a<Tbody>
with theisExpanded
prop, which contains two<Tr>
s: one for the row itself and one for the expanded content.Also removes the
cursor: "pointer"
inline style on theTbody
which was causing the whole row to appear clickable even though only the expandable cells are clickable.