✨ Fetch export questionnaire and application static report with refactor.

[gildub]

Use file-saver package similarly as the download approach for the application static report.

Refactor the application static report download hook :

• Move the useFetchStaticReport (former useDownloadStaticReport) within queries/applications.ts because it's tapping into applications ressource.
• As the download is only fetching (GET) the report data this is not a mutation.

Resolves #1262

[codecov]

Codecov Report

Patch coverage: 38.09% and project coverage change: +0.02% 🎉

Comparison is base (fd89fb8) 42.38% compared to head (e431887) 42.41%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1322      +/-   ##
==========================================
+ Coverage   42.38%   42.41%   +0.02%     
==========================================
  Files         137      138       +1     
  Lines        4294     4315      +21     
  Branches     1010     1017       +7     
==========================================
+ Hits         1820     1830      +10     
- Misses       2462     2473      +11     
  Partials       12       12              

Flag	Coverage Δ
client	42.41% <38.09%> (+0.02%)	⬆️
server	∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
client/src/app/api/rest.ts	54.09% <20.00%> (-0.81%)	⬇️
client/src/app/queries/questionnaires.ts	22.22% <25.00%> (+0.79%)	⬆️
client/src/app/queries/applications.ts	47.54% <50.00%> (+0.17%)	⬆️
client/src/app/api/models.ts	100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mturley]

+1 to Ian's feedback, LGTM otherwise.

Edit: Mea culpa, I reviewed without testing and didn't catch the below issues. Will review again.

[ibolton336]

Something isn't looking right in the drawer

[gildub]

@ibolton336, we're getting the "Error downloading report" as well on main branch when clicking on the YAML or Report links. So is that approach is solid enough ?

I'm investigating...

[sjd78]

The change is looking nice and clean now. Only a single nit-pick, but not a blocker.

Looks like all of Ian's comments were addressed.

[sjd78]

I think one more step to get the button text (or react node) to render is still needed.

[sjd78]

LGTM

[ibolton336]

Looks like this broke the tar download functionality and the loading spinner in the app analysis detail drawer.