✨ Add search toolbar and "all questions" tab to questionnaire view page, clean up layout #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1313 +/- ##
=======================================
Coverage 43.04% 43.04%
=======================================
Files 145 145
Lines 4330 4330
Branches 999 999
=======================================
Hits 1864 1864
Misses 2454 2454
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mturley
force-pushed
the
1293-questionnaire-view-toolbar
branch
from
8e5fa98 to
7e3e829
Compare
mturley
changed the title
Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
mturley
force-pushed
the
1293-questionnaire-view-toolbar
branch
from
d4c3914 to
8d54cd3
Compare
ibolton336
pushed a commit
to ibolton336/tackle2-ui
that referenced
this pull request
Aug 29, 2023
…ge, clean up layout (konveyor#1313) Resolves konveyor#1293. We determined we don't need the filter dropdown (at least for now), just the search bar. * Cleans up some layout issues on the page. * Adds an "All questions" tab above the section tabs. When viewing this tab, the questions table has a "Section" column so you can still tell the sections apart when they are viewed together. * Adds the total number of questions under each tab title. When the search bar is used, a badge appears next to this to show how many questions match the search. * Adds an empty state to the table if there are no questions matching your search. <img width="1500" alt="Screenshot 2023-08-25 at 2 24 18 PM" src="https://github.com/konveyor/tackle2-ui/assets/811963/c655ba4e-4a18-493a-87ad-ff1e3c926da3">  <img width="1501" alt="Screenshot 2023-08-25 at 2 31 19 PM" src="https://github.com/konveyor/tackle2-ui/assets/811963/27e547c8-76dc-4398-9a2f-84cd9da64e8c"> --------- Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1293. We determined we don't need the filter dropdown (at least for now), just the search bar.