Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Bump all PF react-core deps to V5 release #1226

Merged
merged 2 commits into from
Jul 28, 2023
Merged

🌱 Bump all PF react-core deps to V5 release #1226

merged 2 commits into from
Jul 28, 2023

Conversation

gildub
Copy link
Contributor

@gildub gildub commented Jul 28, 2023

No description provided.

Signed-off-by: Gilles Dubreuil <gdubreui@redhat.com>
@gildub gildub changed the title 🌱 Bump all PF react-core to V5 release 🌱 Bump all PF react-core deps to V5 release Jul 28, 2023
@gildub gildub self-assigned this Jul 28, 2023
@gildub gildub requested a review from sjd78 July 28, 2023 13:33
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than some confusion on my part about why use ^5.1.0 instead of ^5.0.0, LGTM

Signed-off-by: Gilles Dubreuil <gdubreui@redhat.com>
@gildub gildub merged commit 7fff5a4 into konveyor:main Jul 28, 2023
@gildub gildub deleted the bump-pf5-release branch July 28, 2023 15:39
mturley added a commit that referenced this pull request Jul 28, 2023
…ockfile (#1228)

#1226 bumped lib-ui to 9.0.2 but that version still uses prerelease PF
versions. we need version 9.0.3 which was released with
migtools/lib-ui#137

Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants