🐛 [backport release-0.2] Allow the select and multiselect filter controls to scroll content #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add param `isScrollable`, and released css, to allow the patternfly `Select` components at the core of `SelectFilterControl` and `MultiselectFilterControl` to scroll its content as needed. This is a replication of the patternfly Menu `isScrollable` prop[1]. Summary of changes: - Add `isScrollable` (with a default value of `false`) to `SelectFilterControl` and `MultiselectFilterControl` - Add `select-overrides.css` to implement the scrolling for the components - Minor tweaks to the filter select controls to mirror code formatting as they are very similar components Backport of konveyor#1094 [1]: https://www.patternfly.org/v4/components/menu#scrollable-menus Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## release-0.2 #1113 +/- ##
===============================================
- Coverage 46.95% 46.93% -0.02%
===============================================
Files 177 177
Lines 4432 4442 +10
Branches 987 991 +4
===============================================
+ Hits 2081 2085 +4
- Misses 2337 2343 +6
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
ibolton336
approved these changes
Jul 11, 2023
mturley
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add param
isScrollable, and released css, to allow the patternflySelectcomponents at the core ofSelectFilterControlandMultiselectFilterControlto scroll its content as needed. This is a replication of the patternfly MenuisScrollableprop[1].Summary of changes:
Add
isScrollable(with a default value offalse) toSelectFilterControlandMultiselectFilterControlAdd
select-overrides.cssto implement the scrolling for the componentsMinor tweaks to the filter select controls to mirror code formatting as they are very similar components
Backport of #1094
[1]: https://www.patternfly.org/v4/components/menu#scrollable-menus