-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
View report / task data in yaml #835
Comments
@ibolton336, is this still on the radar as the analyzers report format was going to cover for it ? |
Duplicated by https://issues.redhat.com/browse/MTA-773 With the current way of opening the details, only the default mime type for the service endpoint can be used: onClick: () => {
const task = getTask(row);
if (task) window.open(`/hub/tasks/${task.id}`, "_blank");
}, const openAnalysisDetails = () => {
if (task) window.open(`/hub/tasks/${task.id}`, "_blank");
}; A reasonable way forward would be to use a Maybe navigate to a new route in the normal application page? Maybe have a skinny viewer app using a separate webpack entry point all together? Thoughts @ibolton336 , @gildub , @mturley ? |
I think we probably don't want to take the user away from their current browser tab for this if we can help it (I know we currently do, but I think that was out of convenience since this was the easiest way to pull up raw data?) My vote would be to open a modal with a read-only code viewer, just like #1057 as suggested. |
Instead of opening a new browser window to show a user a json formatted analysis details document, open a modal on page with an embedded and enhanced CodeEditor. The `SimpleDocumentViewerModal` component allows fetching and displaying the document as either a json or yaml document. Users can request the other format on screen. By using the `@patternfly/react-code-editor` component, a number of good things are enabled: - the content is displayed on page and is code colored per language - the contents can be copied to the clipboard - the contents can be save to a file - the user can easily view either the json or yaml format of the same document, as provided by the rest api endpoint Resolves: #835 Resolves: https://issues.redhat.com/browse/MTA-773 Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
The text was updated successfully, but these errors were encountered: