Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Prefix application binary coordinates with mvn://. #1967

Closed
jortel opened this issue Jun 18, 2024 · 1 comment · Fixed by #1968
Closed

✨ Prefix application binary coordinates with mvn://. #1967

jortel opened this issue Jun 18, 2024 · 1 comment · Fixed by #1968
Assignees
@ibolton336
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/normal Higher priority than priority/minor. Nice to have. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
v0.5.0

Comments

@jortel
Copy link
Contributor

jortel commented Jun 18, 2024

Prefix application binary coordinates with mvn://.
Current:

io.konveyor.demo:customers-tomcat:0.0.1-SNAPSHOT:war

Changed to:

mvn://io.konveyor.demo:customers-tomcat:0.0.1-SNAPSHOT:war
@konveyor-ci-bot konveyor-ci-bot bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jun 18, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Jun 18, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Jun 18, 2024
@ibolton336 ibolton336 self-assigned this Jun 18, 2024
@ibolton336 ibolton336 mentioned this issue Jun 19, 2024
Merged
@sjd78 sjd78 added this to the v0.5.0 milestone Jun 19, 2024
@sjd78 sjd78 moved this from 🆕 New to 🏗 In progress in Planning Jun 19, 2024
@sjd78 sjd78 added kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/normal Higher priority than priority/minor. Nice to have. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Jun 19, 2024
sjd78 pushed a commit that referenced this issue Jun 20, 2024
@ibolton336
✨ Add mvn:// prefix to application binary value in post request (#1968)
a3ef502 
Resolves: #1967

Note: validation is not necessary since the ui already breaks up the
input into separate for fields and composes the binary coordinates under
the hood.

---------

Signed-off-by: Ian Bolton <ibolton@redhat.com>
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Planning Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ibolton336 ibolton336

Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/normal Higher priority than priority/minor. Nice to have. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Planning
Status: ✅ Done
Milestone
v0.5.0
Development

Successfully merging a pull request may close this issue.

✨ Add mvn:// prefix to application binary value in post request ibolton336/tackle2-ui
3 participants
@jortel @sjd78 @ibolton336