Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check existing archetypes when starting an app assessment #1298

Closed
ibolton336 opened this issue Aug 22, 2023 · 2 comments · Fixed by #1368
Closed

Check existing archetypes when starting an app assessment #1298

ibolton336 opened this issue Aug 22, 2023 · 2 comments · Fixed by #1368
Assignees
@ibolton336
Labels
Custom Assessment Items relating to custom assessment work

Comments

@ibolton336
Copy link
Member

ibolton336 commented Aug 22, 2023 •
edited
Loading

  • Wire up check for existing assessments from archetypes when starting an app assessment
  • Add a view assessments action to the assessment modal as shown in the wireframe. It is unclear if accept & view assessments take the user to the same assessment actions page with different state. TODO: View assessments page for existing assessments

Image
@ibolton336 ibolton336 converted this from a draft issue Aug 22, 2023
@ibolton336 ibolton336 added the Custom Assessment Items relating to custom assessment work label Aug 22, 2023
@ibolton336
Copy link
Member Author

@JustinXHale What happens when a user clicks accept vs View assessments? Shouldn't they both take you to this page:

Image

@JustinXHale
Copy link
Member

Kind of. If a user clicks accept, they will start a new assessment so they will see the "Take" button next to the questionnaire. If the were to click View Assessment, those buttons would say "View" and clicking would take them to the questionnaire responses.
image
image

@ibolton336 ibolton336 mentioned this issue Aug 22, 2023
Merged
ibolton336 added a commit that referenced this issue Aug 24, 2023
@ibolton336
✨ Convert assessment table to new table & begin assessment flow chang…
c763fc3 
…es (#1294)

- Update questionnaire TS model to match hub proposal

```
type Questionnaire struct {
	Resource
	Name         string
	Description  string
	Revision     uint
	Required     bool
	Sections     []Section
	Thresholds   Thresholds
	RiskMessages RiskMessages
}

type Assessment struct {
	Resource
	Application   *Ref
	Archetype     *Ref
	Questionnaire *Ref
	Sections      []Section
}

```
- Convert assessment table to use new table format
- No longer allow bulk assessment on assessment page top level toolbar
as this functionality is moving to Archetypes. Review & assessment
buttons moved to dropdown kebabs on the row level.
- Assessment Actions page with application level
questionnaires/assessments listed. TODO: [Add dynamic actions
button](#1299) based on
current assessment status
- Adds placeholder assessment modal when assessment action is triggered
from the assessment table row. TODO: [Add existing archetype
check](#1298)
- TODO: [View assessments page for existing
assessments](#1301) for
viewing existing assessments when clicking assess on an application that
already has an associated completed assessment
- TODO: [Convert assessment wizard
](#1306)
-TODO: Fix empty state initial render
#1311

Signed-off-by: ibolton336 <ibolton@redhat.com>
ibolton336 added a commit to ibolton336/tackle2-ui that referenced this issue Aug 24, 2023
@ibolton336
✨ Convert assessment table to new table & begin assessment flow chang…
24883ae 
…es (konveyor#1294)

- Update questionnaire TS model to match hub proposal

```
type Questionnaire struct {
	Resource
	Name         string
	Description  string
	Revision     uint
	Required     bool
	Sections     []Section
	Thresholds   Thresholds
	RiskMessages RiskMessages
}

type Assessment struct {
	Resource
	Application   *Ref
	Archetype     *Ref
	Questionnaire *Ref
	Sections      []Section
}

```
- Convert assessment table to use new table format
- No longer allow bulk assessment on assessment page top level toolbar
as this functionality is moving to Archetypes. Review & assessment
buttons moved to dropdown kebabs on the row level.
- Assessment Actions page with application level
questionnaires/assessments listed. TODO: [Add dynamic actions
button](konveyor#1299) based on
current assessment status
- Adds placeholder assessment modal when assessment action is triggered
from the assessment table row. TODO: [Add existing archetype
check](konveyor#1298)
- TODO: [View assessments page for existing
assessments](konveyor#1301) for
viewing existing assessments when clicking assess on an application that
already has an associated completed assessment
- TODO: [Convert assessment wizard
](konveyor#1306)
-TODO: Fix empty state initial render
konveyor#1311

Signed-off-by: ibolton336 <ibolton@redhat.com>
@dymurray dymurray moved this to 📋 Backlog in Planning Sep 15, 2023
@ibolton336 ibolton336 self-assigned this Sep 19, 2023
@ibolton336 ibolton336 moved this from Todo to In Progress in Konveyor UI Sep 19, 2023
@ibolton336 ibolton336 mentioned this issue Sep 19, 2023
Merged
ibolton336 added a commit that referenced this issue Sep 19, 2023
@ibolton336
✨ Fix missing archetype flow pieces (#1368)
c36b614 
Closes #1298 #1278 #1332 #1324 
- Adjusts routes for archetype assessment flow vs application assessment
flow
- Creates a hook for looking up app or archetype based on their ID to
avoid conditional hook calls.
- Wire up create assessment override check 
<img width="1918" alt="Screenshot 2023-09-18 at 12 33 20 PM"
src="https://github.com/konveyor/tackle2-ui/assets/11218376/53d91eba-ec43-46c2-ada7-68f384d9b3a7">
-Drive assessment wizard from assessment rather than questionnaire


- With this PR, assessment flow is fully working for apps and archetypes
against the hub outstanding PR.

Signed-off-by: ibolton336 <ibolton@redhat.com>
@ibolton336 ibolton336 moved this from In Progress to Done in Konveyor UI Sep 21, 2023
@dymurray dymurray moved this from 📋 Backlog to ✅ Done in Planning Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ibolton336 ibolton336

Labels
Custom Assessment Items relating to custom assessment work
Projects
Planning
Status: ✅ Done
Konveyor UI
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ Fix missing archetype flow pieces ibolton336/tackle2-ui
2 participants
@ibolton336 @JustinXHale