Skip to content

Commit

Permalink
🌱 [backport release-0.4] Add and allow test image builds for more cha…
Browse files Browse the repository at this point in the history
…nges (#1926) (#1927)

Changes:
  - If any of the `package.json` files change, test the image builds. We
    want to make sure that changes to the `engine` or `script` blocks
    receive a full image build testing.

  - Update the npm version check to `>=9.5.0`. This will allow the test
    image build CI to check new builder images that also have npm major
    version updates.

Backport-of: #1926
Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
Signed-off-by: Cherry Picker <noreply@github.com>
  • Loading branch information
konveyor-ci-bot[bot] authored May 29, 2024
1 parent 6940c46 commit d126553
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/workflows/ci-image-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ jobs:
with:
files: |
Dockerfile
**/package.json
package-lock.json
- name: Check if build related files have been changed in a PR
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
],
"engines": {
"node": ">=18.14.2",
"npm": "^9.5.0"
"npm": ">=9.5.0"
},
"devDependencies": {
"@rollup/plugin-commonjs": "^25.0.7",
Expand Down

0 comments on commit d126553

Please sign in to comment.