🐛 adding discovery label to be used in discovery process #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shawn Hurley <shawn@hurley.page>
shawn-hurley
force-pushed
the
bugfix/add-discovery-to-tech-usage
branch
from
f885662 to
43e8a29
Compare
dymurray
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that is is need, for the technology rules to be selected by default.
The default label is here:
https://github.com/konveyor/tackle2-hub/blob/main/settings/hub.go#L279-L280
which whill IIUC find the task here:
https://github.com/konveyor/operator/blob/main/roles/tackle/templates/customresource-addon-tech-discovery.yml.j2#L106-L124
which is using
IIUC this information is seeded in the database for when retrieving rules, right now I have a feeling that only the
00_discoveryrules are run in discovery tasks