Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Prevent action panic from killing the task manager. #650

Merged
merged 1 commit into from
Jun 11, 2024
Merged

🐛 Prevent action panic from killing the task manager. #650

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions task/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,10 +282,18 @@ func (m *Manager) pause() {

// action executes an asynchronous action.
func (m *Manager) action(action func() error) (err error) {
d := time.Hour
d := time.Minute
ch := make(chan error)
m.queue <- func() {
defer close(ch)
defer func() {
p := recover()
if p != nil {
if err, cast := p.(error); cast {
ch <- err
}
}
close(ch)
}()
select {
case ch <- action():
default:
Expand Down
Loading