🐛 Add Token refresh to export/import CLI #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On slow environments or large data, export/import/clean-all CLI commands might take more than token lifetime is (5 minutes). Adding automatic token refresh and doing necessary refactoring to make it possible. Signed-off-by: Marek Aufart <maufart@redhat.com>
mansam
approved these changes
Jun 4, 2024
shawn-hurley
reviewed
Jun 4, 2024
hack/tool/tackle
Outdated
| def checkTokenLifetime(self): | ||
| if self.TokenRenewAfter < int(time.time()): | ||
| self.Token = getHubToken(self.Url, c['username'], c['password'], False) | ||
| self.TokenRenewAfter = int(time.time()) + 4*60 # 4 minutes to refresh token |
There was a problem hiding this comment.
Shouldn't the token have this information? If an auth provider has a shorter refresh token, this will fail, I think.
There was a problem hiding this comment.
You're right. The supported go-based implementation also uses Refresh call instead of new Login (https://github.com/konveyor/tackle2-hub/blob/main/binding/client.go#L781).
For this semi/un-supported Python script, that is planned to be replaced with a golang-based tooling, this could be a quickfix IMO.
The time was moved to constant to allow easier adjustment in case of problems.
There was a problem hiding this comment.
quick fix makes sense, was just a concern, if this is not going to live for much longer I am good :)
Signed-off-by: Marek Aufart <maufart@redhat.com>
This was referenced Jun 22, 2024
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On slow environments or large data, export/import/clean-all CLI commands might take more than token lifetime is (5 minutes), that failed the operation.
Adding automatic token refresh and doing necessary refactoring to make it possible.