👻 add hack to generate jwt token. #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Ortel <jortel@redhat.com>
mansam
approved these changes
Oct 19, 2023
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
jortel
commented
Oct 23, 2023
| @@ -71,9 +74,15 @@ type Builtin struct { | |||
| // | |||
| // Authenticate the token | |||
| func (r *Builtin) Authenticate(request *Request) (jwToken *jwt.Token, err error) { | |||
| token := request.Token | |||
| token := strings.Replace(request.Token, "Bearer", "", 1) | |||
| token = strings.Fields(token)[0] | |||
There was a problem hiding this comment.
hint: support proper header value: Authorization: <type> <token>.
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
jortel
commented
Oct 23, 2023
| @@ -93,32 +102,52 @@ func (r *Builtin) Authenticate(request *Request) (jwToken *jwt.Token, err error) | |||
| } | |||
| claims, cast := jwToken.Claims.(jwt.MapClaims) | |||
| if !cast { | |||
| err = liberr.Wrap(&NotAuthenticated{Token: token}) | |||
| err = liberr.Wrap( | |||
| &NotValid{ | |||
There was a problem hiding this comment.
hint: This (and below) is a token validation error, not authentication.
jortel
commented
Oct 23, 2023
| } | ||
|
|
||
| func (e *NotAuthenticated) Is(err error) (matched bool) { | ||
| _, matched = err.(*NotAuthenticated) | ||
| notAuth := &NotAuthenticated{} | ||
| matched = errors.As(err, ¬Auth) |
There was a problem hiding this comment.
hint: Using As() is more robust in case of wrapped errors.
mansam
approved these changes
Oct 24, 2023
| @@ -22,26 +24,34 @@ type Validator struct { | |||
| // - The token references a task. | |||
| // - The task is valid and running. | |||
| // - The task pod valid and pending|running. | |||
| func (r *Validator) Valid(token *jwt.Token, db *gorm.DB) (valid bool) { | |||
| var err error | |||
| func (r *Validator) Valid(token *jwt.Token, db *gorm.DB) (err error) { | |||
There was a problem hiding this comment.
Really like this refactor.
aufi
pushed a commit
to aufi/tackle2-hub
that referenced
this pull request
Oct 30, 2023
Add hack script to generate jwt tokens for _builtin_ auth. Likley used by actors such as the operator for migration related to upgrade. Related: - auth.Validator signature changed to return error. This is more flexible and _failures_ can be propagated. - auth.Builtin.Authenticate() returns NotAuthenticated when should have returned NotValid for clearity. - auth.NotValid includes `Reason`. --------- Signed-off-by: Jeff Ortel <jortel@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add hack script to generate jwt tokens for builtin auth. Likley used by actors such as the operator for migration related to upgrade.
Related:
Reason.