Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👻 Fix Ruleset API test after refactoring #467

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

aufi
Copy link
Member

@aufi aufi commented Aug 3, 2023

Image is not part of Ruleset anymore, removing from sample Rulesets.

Related to #464

Image is not part of Ruleset anymore, removing from sample Rulesets.
Related to konveyor#464

Signed-off-by: Marek Aufart <maufart@redhat.com>
@aufi
Copy link
Member Author

aufi commented Aug 3, 2023

@jortel @mansam It would be great not merging PRs with failing (API) tests unless it is an emergency case. If there's some thing tricky with tests, please ping me.

@aufi aufi mentioned this pull request Aug 3, 2023
Copy link
Contributor

@jortel jortel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jortel jortel merged commit a51c0eb into konveyor:main Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants