Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Task fails when ResourceQuota exceeded. #625

Closed
1 task done
jortel opened this issue Apr 14, 2024 · 1 comment · Fixed by #627
Closed
1 task done

[BUG] Task fails when ResourceQuota exceeded. #625

jortel opened this issue Apr 14, 2024 · 1 comment · Fixed by #627
Assignees
@jortel
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/minor Lowest priority. Possibly useful, but not yet enough support to actually get it done. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
v0.3.2

Comments

@jortel
Copy link
Contributor

jortel commented Apr 14, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Konveyor version

0.3

Priority

Critical

Current Behavior

Pod create fails when ResourceQuota exists which causes the task to fail.

Expected Behavior

Task manager should detect the Pod create failed with Forbidden (403) and reason "quota exceeded." and leave the task in the Ready state to be retried.

How Reproducible

Always (Default)

Steps To Reproduce

  1. Create a ResourceQuota in the konveyor-tackle namespace.
  2. Run bulk analysis with enough applications to exceed the quota.

Environment

- OS:

Anything else?

apiVersion: v1
kind: ResourceQuota
metadata:
  name: task-pods
spec:
  hard:
    cpu: "6"
    memory: 7Gi
    pods: "10"
@jortel jortel added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 14, 2024
@jortel jortel added this to the v0.3.2 milestone Apr 14, 2024
@jortel jortel self-assigned this Apr 14, 2024
@jortel jortel added this to Planning Apr 14, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Apr 14, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added the needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. label Apr 14, 2024
@jortel jortel changed the title [BUG] <title> [BUG] Task fails when ResourceQuota exceeded. Apr 14, 2024
@jortel jortel added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Apr 14, 2024
@konveyor-ci-bot konveyor-ci-bot bot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Apr 14, 2024
@jortel jortel added priority/critical Must be staffed and worked on either currently, or very soon, ideally in time for the next release. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/minor Lowest priority. Possibly useful, but not yet enough support to actually get it done. and removed priority/critical Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Apr 14, 2024
@konveyor-ci-bot konveyor-ci-bot bot removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Apr 14, 2024
@jortel jortel moved this from 🆕 New to 🏗 In progress in Planning Apr 14, 2024
@jortel jortel mentioned this issue Apr 18, 2024
Merged
@jortel jortel moved this from 🏗 In progress to ✅ Done in Planning Apr 25, 2024
jortel added a commit that referenced this issue Apr 25, 2024
@jortel
🐛 Fix Fail when Resource Quota exceeded. (#627)
cdc096f 
Detect resource quota exceeded and leave the task.State=Ready.

closes #625

---------

Signed-off-by: Jeff Ortel <jortel@redhat.com>
mansam pushed a commit to mansam/tackle2-hub that referenced this issue Apr 30, 2024
@jortel @mansam
🐛 Fix Fail when Resource Quota exceeded. (konveyor#627)
fff6e9f 
Detect resource quota exceeded and leave the task.State=Ready.

closes konveyor#625

---------

Signed-off-by: Jeff Ortel <jortel@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jortel jortel

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/minor Lowest priority. Possibly useful, but not yet enough support to actually get it done. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Planning
Status: ✅ Done
Milestone
v0.3.2
Development

Successfully merging a pull request may close this issue.

🐛 Fix Fail when Resource Quota exceeded. jortel/tackle2-hub
1 participant
@jortel