Fix missing returns in BaseHandler.Bind* methods

konveyor · Sep 19, 2023 · 2135b7a · 2135b7a
1 parent 75172b5
commit 2135b7a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/api/application.go b/api/application.go
@@ -1054,7 +1054,7 @@ type Application struct {
 	Comments        string      `json:"comments"`
 	Identities      []Ref       `json:"identities"`
 	Tags            []TagRef    `json:"tags"`
-	BusinessService *Ref        `json:"businessService" yaml:"businessService"`
+	BusinessService *Ref        `json:"businessService"`
 	Owner           *Ref        `json:"owner"`
 	Contributors    []Ref       `json:"contributors"`
 	MigrationWave   *Ref        `json:"migrationWave"`

diff --git a/api/base.go b/api/base.go
@@ -186,6 +186,7 @@ func (h *BaseHandler) Bind(ctx *gin.Context, r interface{}) (err error) {
 func (h *BaseHandler) BindJSON(ctx *gin.Context, r interface{}) (err error) {
 	if ctx.Request == nil || ctx.Request.Body == nil {
 		err = errors.New("invalid request")
+		return
 	}
 	decoder := json.NewDecoder(ctx.Request.Body)
 	decoder.DisallowUnknownFields()
@@ -204,6 +205,7 @@ func (h *BaseHandler) BindJSON(ctx *gin.Context, r interface{}) (err error) {
 func (h *BaseHandler) BindYAML(ctx *gin.Context, r interface{}) (err error) {
 	if ctx.Request == nil || ctx.Request.Body == nil {
 		err = errors.New("invalid request")
+		return
 	}
 	decoder := yaml.NewDecoder(ctx.Request.Body)
 	decoder.SetStrict(true)