🐛 Adding ability to set the scope for the analysis command

[shawn-hurley]

No description provided.

[shawn-hurley]

I would argue that something along this line would be useful, sounds like you have something in the works so will remove

[shawn-hurley]

@fabianvf @jortel enables the testing of the package filters.

A follow up PR for go-konveyor-tests is incoming

[shawn-hurley]

This is needed for this konveyor test: konveyor/go-konveyor-tests#76

[jortel]

Thanks for the PR @shawn!
Few things:

• Please add (at lease a short) description to PR.
• Rather than adding a code block into AddOptions(), please add a method that builds the selector for better functional decomposition and testability.
• Please add a unit test.
• The logic seems to prefix (!package ||. Is this intentional or side effect of logic?
• I tested in Go Playground and found some issues with the generated selector. Also demonstrates a simpler (IMHO) approach that solves them. Please: See/Consider: Scope.incidentSelector().

Issues (I think):

1. Extra !package prefix?
2. Missing closing ) when both included and excluded specified.
3. Excluded in the selector as (!package=a||!package=b) should be !(package=a||package=b).
4. Exclude only creates selector of (!package) should be !(package||package=C||package=D).

Test output:

pr69()
	Empty => ''
	Included only. => '(!package || package=a || package=b)'
	included and exluded => '(!package || package=a || package=b) && (!package || !package=C || !package=D'
	Excluded only. => '(!package)'

incidentSelector()
	Empty => ''
	Included only. => '(package=a||package=b)'
	included and excluded => '(package=a||package=b)&&!(package=C||package=D)'
	Excluded only. => '!(package=C||package=D)'

---

Long term:
The packages list of included/excluded in the addon API needs to be re-modeled to be more generic and the caller (UI) should pass arrays of package=<name> (like we do for labels). For now this is a left over from Windup which was 100% java specific.

[jortel]

Replaced by: #70