Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eap7 weblogic NonCatalogLogger constructor #241

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

aufi
Copy link
Member

@aufi aufi commented Feb 4, 2025

Updating contructor selector to be more generic and match expected incidents. Note, this quite generic selector is not ideal, but works better than previous version that didn't matched well.

Related to: https://issues.redhat.com/browse/MTA-3845

Updating contructor selector to be more generic and match expected
incidents. Note, this quite generic selector is not ideal, but works better
than previous version that didn't matched well.

Related to: https://issues.redhat.com/browse/MTA-3845

Signed-off-by: Marek Aufart <maufart@redhat.com>
@aufi aufi requested a review from jmle February 4, 2025 16:06
@aufi aufi added the cherry-pick/release-0.6 This PR should be cherry-picked to release-0.6 branch label Feb 4, 2025
Signed-off-by: Marek Aufart <maufart@redhat.com>
Copy link
Contributor

@jmle jmle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aufi
Copy link
Member Author

aufi commented Feb 4, 2025

The UI failure looks to be some Tag CRUD started with some timeout, I don't think it is related to rulesets, tried restart the job.

image

image

@aufi
Copy link
Member Author

aufi commented Feb 5, 2025

The UI test failure is a known issue https://issues.redhat.com/browse/MTA-4574 and unrelated, going to merge this.

@aufi aufi merged commit 439d120 into konveyor:main Feb 5, 2025
5 of 6 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 5, 2025
* Update eap7 NonCatalogLogger constructor

Updating contructor selector to be more generic and match expected
incidents. Note, this quite generic selector is not ideal, but works better
than previous version that didn't matched well.

Related to: https://issues.redhat.com/browse/MTA-3845

Signed-off-by: Marek Aufart <maufart@redhat.com>

* Update artifact workflow action

Signed-off-by: Marek Aufart <maufart@redhat.com>

---------

Signed-off-by: Marek Aufart <maufart@redhat.com>
Signed-off-by: Cherry Picker <noreply@github.com>
dymurray pushed a commit that referenced this pull request Feb 6, 2025
* Update eap7 weblogic NonCatalogLogger constructor (#241)

* Update eap7 NonCatalogLogger constructor

Updating contructor selector to be more generic and match expected
incidents. Note, this quite generic selector is not ideal, but works better
than previous version that didn't matched well.

Related to: https://issues.redhat.com/browse/MTA-3845

Signed-off-by: Marek Aufart <maufart@redhat.com>

* Update artifact workflow action

Signed-off-by: Marek Aufart <maufart@redhat.com>

---------

Signed-off-by: Marek Aufart <maufart@redhat.com>
Signed-off-by: Cherry Picker <noreply@github.com>

* Use corresponding API tests branch

Signed-off-by: Marek Aufart <maufart@redhat.com>

---------

Signed-off-by: Marek Aufart <maufart@redhat.com>
Signed-off-by: Cherry Picker <noreply@github.com>
Co-authored-by: Marek Aufart <aufi.cz@gmail.com>
Co-authored-by: Marek Aufart <maufart@redhat.com>
aufi added a commit to aufi/rulesets that referenced this pull request Feb 12, 2025
Updating NonCatalogLogger reference to be even more generic (to cover
PromoService.java sample file).

Related to: konveyor#241
Fixes: https://issues.redhat.com/browse/MTA-3845

Signed-off-by: Marek Aufart <maufart@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/release-0.6 This PR should be cherry-picked to release-0.6 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants