🐛 : Fix support for python and nodejs. #401
Open
+91
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
jortel
commented
Feb 7, 2025
| @@ -181,7 +190,7 @@ provider_java_container_requests_cpu: "1" | |||
| provider_java_container_requests_memory: "2Gi" | |||
| provider_java_image_fqin: "{{ lookup('env', 'RELATED_IMAGE_PROVIDER_JAVA') }}" | |||
| provider_java_name: "java" | |||
| provider_java_service_name: "{{ app_name }}-{{ provider_java_name }}-{{ analyzer_component_name }}" | |||
| provider_java_service_name: "{{ app_name }}-{{ provider_java_name }}-{{ provider_java_component_name }}" | |||
There was a problem hiding this comment.
hint: Fixing what seems to be a cut-n-paste error.
jortel
commented
Feb 7, 2025
| @@ -512,11 +512,21 @@ | |||
| name: "{{ admin_name }}" | |||
| namespace: "{{ app_namespace }}" | |||
|
|
|||
| - name: "Create Windup Addon CR" | |||
| - name: "Create Analyzer Addon CR" | |||
There was a problem hiding this comment.
hint: More accurate name.
|
Looks good with one question, I understood we want add "dedicated" python and nodejs providers, but I'm missing why we want delete the generic provider (not a bloker, I'm likely missing some background discussions/requirements, just wanted to mention it). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor generic provider into separate python and nodejs extensions with correct metadata.
closes #399
requires: