Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 pin provider images in our release artifacts #347

Merged
merged 1 commit into from
Jul 2, 2024
Merged

🌱 pin provider images in our release artifacts #347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/actions/make-bundle/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,14 @@ inputs:
description: "image uri for discovery addon (ie. quay.io/<namespace>/<image-name>:<tag>)"
required: false
default: ""
provider_generic:
description: "image uri for generic provider (ie. quay.io/<namespace>/<image-name>:<tag>)"
required: false
default: ""
provider_java:
description: "image uri for generic provider (ie. quay.io/<namespace>/<image-name>:<tag>)"
required: false
default: ""
version:
description: "operator version"
required: false
Expand Down Expand Up @@ -70,6 +78,8 @@ runs:
[ -n "${{ inputs.tackle_ui }}" ] && OPTS+=" --set images.tackle_ui=${{ inputs.tackle_ui }}"
[ -n "${{ inputs.addon_analyzer }}" ] && OPTS+=" --set images.addon_analyzer=${{ inputs.addon_analyzer }}"
[ -n "${{ inputs.addon_discovery }}" ] && OPTS+=" --set images.addon_discovery=${{ inputs.addon_discovery }}"
[ -n "${{ inputs.provider_generic }}" ] && OPTS+=" --set images.provider_generic=${{ inputs.provider_generic }}"
[ -n "${{ inputs.provider_java }}" ] && OPTS+=" --set images.provider_java=${{ inputs.provider_java }}"
HELM_OPTS="${OPTS}" make bundle
cat ./bundle/manifests/konveyor-operator.clusterserviceversion.yaml
make bundle-build
Expand Down
7 changes: 2 additions & 5 deletions .github/workflows/create-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,8 @@ jobs:
tackle_ui: quay.io/konveyor/tackle2-ui:${{ inputs.version }}
addon_analyzer: quay.io/konveyor/tackle2-addon-analyzer:${{ inputs.version }}
addon_discovery: quay.io/konveyor/tackle2-addon-discovery:${{ inputs.version }}
provider_generic: quay.io/konveyor/generic-external-provider:${{ inputs.version }}
provider_java: quay.io/konveyor/java-external-provider:${{ inputs.version }}
# The ones we don't own
oauth_proxy: quay.io/konveyor/origin-oauth-proxy:${{ inputs.version }}
tackle_postgres: quay.io/konveyor/postgresql-15-c9s:${{ inputs.version }}
Expand Down Expand Up @@ -267,11 +269,6 @@ jobs:
uses: konveyor/ci/.github/workflows/global-ci-bundle.yml@main
with:
operator_bundle: quay.io/konveyor/tackle2-operator-bundle:${{ inputs.version }}
tackle_hub: quay.io/konveyor/tackle2-hub:${{ inputs.version }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need these because they should already be defined in the bundle

keycloak_init: quay.io/konveyor/tackle-keycloak-init:${{ inputs.version }}
tackle_ui: quay.io/konveyor/tackle2-ui:${{ inputs.version }}
addon_analyzer: quay.io/konveyor/tackle2-addon-analyzer:${{ inputs.version }}
addon_discovery: quay.io/konveyor/tackle2-addon-discovery:${{ inputs.version }}
api_tests_ref: ${{ inputs.branch }}
ui_tests_ref: ${{ inputs.branch }}

Expand Down
Loading