generated from konveyor/template-repo
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👻 count analysis tags only. #137
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djzager
approved these changes
Jun 25, 2024
aufi
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mguetta1
approved these changes
Jun 26, 2024
Signed-off-by: Jeff Ortel <jortel@redhat.com>
1f1e79f
to
84a329f
Compare
djzager
added a commit
to djzager/go-konveyor-tests
that referenced
this pull request
Jul 3, 2024
This reverts commit 34e46ff.
djzager
added a commit
to djzager/go-konveyor-tests
that referenced
this pull request
Jul 3, 2024
This reverts commit 34e46ff. Signed-off-by: David Zager <dzager@redhat.com>
Merged
djzager
added a commit
that referenced
this pull request
Jul 3, 2024
* Revert "fixing test effort when we remove false postives (#146)" This reverts commit 4bbf075. Signed-off-by: David Zager <dzager@redhat.com> * Revert "adding workflow dispatch for tier 0 tests (#145)" This reverts commit 4e334ac. Signed-off-by: David Zager <dzager@redhat.com> * Revert "Moving Tomcat analysis TC to TIER0 (#125)" This reverts commit 19ad9b7. Signed-off-by: David Zager <dzager@redhat.com> * Revert "Updating hub deps (#138)" This reverts commit 44cdaf7. Signed-off-by: David Zager <dzager@redhat.com> * Revert ":ghost: count analysis tags only. (#137)" This reverts commit 34e46ff. Signed-off-by: David Zager <dzager@redhat.com> --------- Signed-off-by: David Zager <dzager@redhat.com>
shawn-hurley
pushed a commit
to shawn-hurley/go-konveyor-tests
that referenced
this pull request
Jul 3, 2024
Signed-off-by: Jeff Ortel <jortel@redhat.com>
shawn-hurley
added a commit
that referenced
this pull request
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compare tag counts with gotTags instead of gotApp.Tags because gotApp.Tags contains non-analysis tags such as tags added by discovery.
I don't know why gofmt reformatted those indents.