👻 workflow must use correct addon branch #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
pranavgaikwad
added
cherry-pick-approved
shawn-hurley
reviewed
Apr 3, 2024
.github/workflows/demo-testing.yml
Outdated
| @@ -69,3 +68,5 @@ jobs: | |||
| uses: konveyor/ci/.github/workflows/global-ci.yml@main | |||
| with: | |||
| component_name: tackle2-addon-analyzer | |||
| # env.ADDON_REF should work as release branches are identical everywhere | |||
| api_tests_ref: "${{ env.ADDON_REF }}" | |||
There was a problem hiding this comment.
Won't this be an issue when it is a PR?
There was a problem hiding this comment.
uhh ohh, sorry my bad...you're absolutely right
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
|
@shawn-hurley updated now, good catch |
shawn-hurley
approved these changes
Apr 3, 2024
pranavgaikwad
added a commit
that referenced
this pull request
Apr 3, 2024
This reverts commit cbe0801.
pranavgaikwad
added a commit
that referenced
this pull request
Apr 3, 2024
This reverts commit cbe0801. Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
pranavgaikwad
added a commit
that referenced
this pull request
Apr 3, 2024
Reverts #561 Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.