🐛 Test cases for #390 #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 15, 2023
ascheman
force-pushed
the
bugfix/390-workaround
branch
from
ce5d3d2 to
f1694b4
Compare
|
@ascheman could you sign all the commits? |
ascheman
force-pushed
the
bugfix/390-workaround
branch
3 times, most recently
from
5438186 to
19b0ac8
Compare
Signed-off-by: Gerd Aschemann <gerd@aschemann.net>
Signed-off-by: Gerd Aschemann <gerd@aschemann.net>
Signed-off-by: Gerd Aschemann <gerd@aschemann.net>
…eyor#420). Signed-off-by: Gerd Aschemann <gerd@aschemann.net>
Signed-off-by: Gerd Aschemann <gerd@aschemann.net>
ascheman
force-pushed
the
bugfix/390-workaround
branch
from
19b0ac8 to
38090d6
Compare
This was referenced Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding test cases for #390.
The Java example was refactored to make it run (i.e.,
mvn compileat least), and extended by a submodule.The submodule contains a property based dependency version which cannot be immediately resolved, as there is no
propertiesdefinition in the submodule itself.The hotfix provided by #425 prevents the binary from failing.
Nevertheless, the version property should be resolved from the parent pom which is not yet addressed.
As the bug report only was about the SEGV caused by the problem, #390 may be closed anyway.