🐛 Fix compile step #397
Merged
🐛 Fix compile step #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CAUTION: This works currently only with a newer version of Maven (tested with 3.9.5). Signed-off-by: Gerd Aschemann <gerd@aschemann.net>
…Maven process Signed-off-by: Gerd Aschemann <gerd@aschemann.net>
Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
shawn-hurley
reviewed
Nov 2, 2023
|
Do we have a multi-module test case yet? I would love to see that added with/ this change to make sure we don't break that in the future (I am worried about me breaking it :) ) |
Captured in issue here, will add sometime this week #399 |
If it helps: The problem came up in my (company project) multi module build. Tested the patch with that project already. |
pranavgaikwad
approved these changes
Nov 2, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #393
Remove "compile" goal from maven invocations, as some applications may not be compilable with the JDK version we bundle.
Related to #393 and #393