Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Add openapi struct fields for dependency condition #551

Closed
shawn-hurley opened this issue Mar 25, 2024 · 5 comments · Fixed by #592
Closed

[Bug] Add openapi struct fields for dependency condition #551

shawn-hurley opened this issue Mar 25, 2024 · 5 comments · Fixed by #592
Assignees
@shawn-hurley
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@shawn-hurley
Copy link
Contributor

using: https://github.com/swaggest/jsonschema-go?tab=readme-ov-file#field-tags

We should add the title, description, and pattern fields to the struct here:
https://github.com/konveyor/analyzer-lsp/blob/feature/use-open-api/provider/provider.go#L616-L624

You can use this as a starting point for the semver regular expression.

Provider Capability Fields Required Description
dependency name Yes Name of the dependency
nameregex No Regex pattern to match the name
upperbound No Match versions lower than or equal to
lowerbound No Match versions greater than or equal to
@shawn-hurley shawn-hurley added kind/bug Categorizes issue or PR as related to a bug. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Mar 25, 2024
@shawn-hurley shawn-hurley self-assigned this Mar 25, 2024
@konveyor-ci-bot
Copy link

This issue has been marked 'good first issue'
Please, make sure it aligns with the criteria found here

@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Mar 25, 2024
@Vickysomtee
Copy link
Contributor

@shawn-hurley I am available to work on this

@shawn-hurley
Copy link
Contributor Author

@Vickysomtee All yours if you want to work on it!

@Vickysomtee
Copy link
Contributor

We should add the title, description, and pattern fields to the struct here:
https://github.com/konveyor/analyzer-lsp/blob/feature/use-open-api/provider/provider.go#L616-L624

@shawn-hurley the url here returns 404

@shawn-hurley
Copy link
Contributor Author

Sorry @Vickysomtee here is a better link: https://github.com/konveyor/analyzer-lsp/blob/main/provider/provider.go#L616-L624

@Vickysomtee Vickysomtee mentioned this issue Apr 29, 2024
Merged
pranavgaikwad pushed a commit that referenced this issue May 6, 2024
@Vickysomtee
🐛 Add openapi struct fields for dependency condition (#592)
005a232 
fixes #551

---------

Signed-off-by: vickysomtee <vickysomtee@gmail.com>
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Planning May 6, 2024
jmle pushed a commit to jmle/analyzer-lsp that referenced this issue May 20, 2024
@Vickysomtee @jmle
🐛 Add openapi struct fields for dependency condition (konveyor#592)
f524e08 
fixes konveyor#551

---------

Signed-off-by: vickysomtee <vickysomtee@gmail.com>
jmle pushed a commit to jmle/analyzer-lsp that referenced this issue May 20, 2024
@Vickysomtee @jmle
🐛 Add openapi struct fields for dependency condition (konveyor#592)
14358df 
fixes konveyor#551

---------

Signed-off-by: vickysomtee <vickysomtee@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawn-hurley shawn-hurley

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Planning
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Add openapi struct fields for dependency condition Vickysomtee/konveyor-analyzer-lsp
2 participants
@shawn-hurley @Vickysomtee