Skip to content

Commit

Permalink
👻 Improve running as non-root (#473)
Browse files Browse the repository at this point in the history
With this change we can at least run as non-root.

I would also proprose moving binaries that need to be accessible to all
users be installed in /usr/local/bin. But as of right now it seems we
have configs (or something) hard coded to this location.

https://github.com/konveyor/java-analyzer-bundle/blob/main/Dockerfile#L41

https://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch04s09.html

Signed-off-by: Jason Montleon <jmontleo@redhat.com>
  • Loading branch information
jmontleon authored Jan 24, 2024
1 parent f6cdf40 commit 01d0708
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ RUN microdnf install gcc-c++ python-devel python3-devel -y
RUN python3 -m ensurepip --upgrade
RUN python3 -m pip install python-lsp-server

COPY --from=jaeger-builder /go/bin/all-in-one-linux /usr/bin/
COPY --from=jaeger-builder /go/bin/all-in-one-linux /usr/local/bin/all-in-one-linux

COPY --from=yq-builder /usr/bin/yq /usr/bin/yq

Expand All @@ -41,6 +41,7 @@ COPY --from=builder /analyzer-lsp/external-providers/golang-dependency-provider/
COPY provider_container_settings.json /analyzer-lsp/provider_settings.json

WORKDIR /analyzer-lsp
RUN chgrp -R 0 /analyzer-lsp && chmod -R g=u /analyzer-lsp

EXPOSE 16686

Expand Down

0 comments on commit 01d0708

Please sign in to comment.