fix double click

[create-share]

Fix #252

Hi. I review the code about double click. I found there is no compare the double click target to the last mouseup target.

Sorry for my poor English. I wish I could help.

Codes in src/Stage.js:

    _mousedown: function(evt) {
       // ...
        if (shape && shape.isListening()) {
          this.clickStartShape = shape;
          shape._fireAndBubble(MOUSEDOWN, { evt: evt });
        }
        // ...
    },
    _mouseup: function(evt) {
      // workaround for mobile IE to force touch event when unhandled pointer event elevates into a mouse event
      if (Konva.UA.ieMobile) {
        return this._touchend(evt);
      }
      if (!Konva.UA.mobile) {
        this._setPointerPosition(evt);
        var shape = this.getIntersection(this.getPointerPosition()),
          clickStartShape = this.clickStartShape,
          fireDblClick = false,
          dd = Konva.DD;

        if (Konva.inDblClickWindow) {
          fireDblClick = true;
          Konva.inDblClickWindow = false;
        } else if (!dd || !dd.justDragged) {
          // don't set inDblClickWindow after dragging
          Konva.inDblClickWindow = true;
        } else if (dd) {
          dd.justDragged = false;
        }

        setTimeout(function() {
          Konva.inDblClickWindow = false;
        }, Konva.dblClickWindow);

        if (shape && shape.isListening()) {
          shape._fireAndBubble(MOUSEUP, { evt: evt });

          // detect if click or double click occurred
          if (
            Konva.listenClickTap &&
            clickStartShape &&
            clickStartShape._id === shape._id
          ) {
            shape._fireAndBubble(CLICK, { evt: evt });

            if (fireDblClick) {// <--- should check the double click target is the last mouseup target or not
              shape._fireAndBubble(DBL_CLICK, { evt: evt });
            }
          }
        }
        // ...
      }
    },

[lavrton]

Yeah. Can you also write a unit test? In the best scenario, it should FAIL before the fix, and PASS after the fix.

[create-share]

Yeah. I would like to do it.

[lavrton]

Thanks! 👍