Update fill
type to accept CanvasGradient
#1772
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
fill
property, defined inShapeConfig
, only allows for strings to be passed.But despite that it is actually possible to pass
CanvasGradient
to thefill
, and it renders correctly (codesandbox demo)This PR adds
CanvasGradient
as one of possible values offill
, the same way it is done forstroke
:konva/src/Shape.ts
Line 60 in 68b4ea3