Skip to content

Commit

Permalink
Fix flow by allowing optional chaining (facebookarchive#2369)
Browse files Browse the repository at this point in the history
Summary:
**Summary**

Turns out the optional chaining PR (facebookarchive#2330) also broke flow. We should run a flow check automatically before we build, not just strip the types.

**Test Plan**

`flow .`
Pull Request resolved: facebookarchive#2369

Reviewed By: claudiopro

Differential Revision: D20680346

Pulled By: mrkev

fbshipit-source-id: c30392a4e8084521c7e66f303fbc5f4832866e98
  • Loading branch information
mrkev authored and vilemj-Viclick committed Jul 16, 2020
1 parent 2fe458f commit 3060060
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/.flowconfig
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ module.system.haste.paths.blacklist=.*/fbjs/node_modules/.*
module.system.haste.paths.blacklist=.*/node_modules/invariant/.*

esproposal.class_static_fields=enable
esproposal.optional_chaining=enable
suppress_type=$FlowIssue
suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(>=0\\.\\(2[0-8]\\|1[0-9]\\|[0-9]\\).[0-9]\\)? *\\).*\n
suppress_comment=\\(.\\|\n\\)*\\$FlowExpectedError
Expand Down

0 comments on commit 3060060

Please sign in to comment.