Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve/NiFiCluster] Move from volume prefix to pvc label selection for deletion #146

Merged
merged 7 commits into from
Aug 25, 2022
Merged

[Improve/NiFiCluster] Move from volume prefix to pvc label selection for deletion #146

merged 7 commits into from
Aug 25, 2022

Conversation

erdrix
Copy link
Contributor

@erdrix erdrix commented Aug 23, 2022 •
edited
Loading

Q A
Bug fix? no
New feature? no
API breaks? no
Deprecations? no
Related tickets fixes https://konpytika.slack.com/archives/C035X6KP684/p1661183634104389
License Apache 2.0

What's in this PR?

Revert the user experience on using VolumeMount, and keep thefix using labels.

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)
  • Append changelog with changes

r65535
r65535 approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@r65535 r65535 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! My comment might be worth splitting out into it's own PR to change all label names, if you agree with it?

pkg/util/nifi/common.go Outdated Show resolved Hide resolved
@erdrix erdrix requested review from mh013370, juldrixx and r65535 and removed request for mh013370 and r65535 August 24, 2022 20:37
@juldrixx
Copy link
Contributor

Shouldn't the documentation reflect these changes?

@mh013370
Copy link
Member

This seems good to me. I believe the operator will apply the updates seamlessly as well, so i don't suspect any sort of migration is needed.

@erdrix erdrix merged commit 8874319 into master Aug 25, 2022
@juldrixx juldrixx deleted the fix_revert_n_improve_pvc_logic branch May 30, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r65535 r65535 r65535 approved these changes

@juldrixx juldrixx Awaiting requested review from juldrixx

@mh013370 mh013370 Awaiting requested review from mh013370

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erdrix @juldrixx @mh013370 @r65535