Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: offer UI for the plugin, just like what we have on the IDE #40

Open
AndroidDeveloperLB opened this issue Oct 13, 2021 · 4 comments

Comments

@AndroidDeveloperLB
Copy link

Like what we get from this :

image

Come to think of it, what are the advantages of using this plugin over this ?

@fmatosqg
Copy link

fmatosqg commented Nov 4, 2021

@AndroidDeveloperLB I've used that option recently and it's a shitshow, it removes several things that are being used. Also be careful, it doesn't run on all modules. Say you have hello.kt open for editing/typing. It will run on the module that contains hello.kt and the modules it depends on.

This plugin needs a bit of polishing but it gave me ridiculously superior result - only 3 false removals, easy to undo by hand (and configure build.gradle.kts to never touch them again). Compared to Android Studio where I got easily more than 50 false removals and is not configurable. Not to mention I think this plugin found way more things that should be removed (600 lines removed over 50 files today), though not certain since it's been a week since I ran the Android Studio command.

@AndroidDeveloperLB
Copy link
Author

@fmatosqg I know it sometimes has annoying results. No idea how I can set an exclusion list either (to avoid showing me results that I know that shouldn't be removed).
Each time I use this tool, I use it very carefully, checking things that seem like a suspicious false-positive.

Anyway, the request here is to have a nice UI like what we have today.
This way there could be a nice competition and a good alternative to what we have today.

Please try to make it have even better UI. For me, for example, I think it could be nice to tell it what to ignore (and show this list too).

@fmatosqg
Copy link

fmatosqg commented Nov 19, 2021 via email

@AndroidDeveloperLB
Copy link
Author

@fmatosqg The request is not to remove the capability of using it in a command line.
It's to add a way to use it via the IDE, easier, just like the rest of the tools that the IDE has to reach them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants