Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(max-concurrency): fix result collection of max-concurrency test for new iteration directories #1226

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

pmacik
Copy link
Collaborator

@pmacik pmacik commented Jun 20, 2024

Description

Followup to #1163

Issue ticket number and link

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

…or new iteration directories

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
Copy link

openshift-ci bot commented Jun 20, 2024

Hi @pmacik. Thanks for your PR.

I'm waiting for a konflux-ci member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pmacik
Copy link
Collaborator Author

pmacik commented Jun 20, 2024

@psturc Hi, could you please approve/merge this? It should have been part of #1163, but it was unfortunatelly omitted by the last force-push before #1163 was merged (#1163 (comment)): https://github.com/konflux-ci/e2e-tests/compare/dbda4f80cd9346f1d74b42b61f37162e3cff8165..b599c89a34f6981e82775b08c9ca95703aedcfef#diff-e866c599b297034725af9a15c0f0829549dc05becda0121d4bb2b932ca0de300

@psturc
Copy link
Member

psturc commented Jun 20, 2024

/lgtm
/approve

Copy link

openshift-ci bot commented Jun 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: psturc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@psturc psturc merged commit 72c5635 into konflux-ci:main Jun 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants