Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Rails 8.0 support #55

Merged
merged 2 commits into from
Nov 9, 2024
Merged

Add Rails 8.0 support #55

merged 2 commits into from
Nov 9, 2024

Conversation

fcatuhe
Copy link
Contributor

@fcatuhe fcatuhe commented Nov 9, 2024

No description provided.

@nicolas-brousse nicolas-brousse self-requested a review November 9, 2024 20:52
@nicolas-brousse nicolas-brousse added the dependencies Pull requests that update a dependency file label Nov 9, 2024
@nicolas-brousse
Copy link
Member

@fcatuhe thanks for your PR. Rails 8.0 needs ruby >= 3.2.0.

You may remove ruby 3.1 in .github/workflows/test.yml matrix. It should fix the CI.

@fcatuhe
Copy link
Contributor Author

fcatuhe commented Nov 9, 2024

@nicolas-brousse yes, thanks, fixed now. I had ran appraisal rake test locally, but did not catch it does not run all combinations of Ruby & Rails, only on my current version of Ruby.

@nicolas-brousse
Copy link
Member

@fcatuhe Thank you

@nicolas-brousse nicolas-brousse merged commit 07f1150 into komposable:main Nov 9, 2024
13 checks passed
@fcatuhe fcatuhe deleted the support-rails-8-0 branch November 9, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-brousse nicolas-brousse nicolas-brousse approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fcatuhe @nicolas-brousse