Fix linter warnings #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@avagin PTAL 🙏🏻 |
|
This branch is 9 commits ahead of @kolyshkin |
avagin
reviewed
Jul 23, 2024
capability_linux.go
Outdated
| status_path = fmt.Sprintf("/proc/%d/status", c.hdr.pid) | ||
| path := "/proc/self/status" | ||
| if c.hdr.pid != 0 { | ||
| path = "/proc/" + strconv.Itoa(int(c.hdr.pid)) + "/status" |
There was a problem hiding this comment.
nit: I think Sprintf looks better for this case.
|
LGTM |
Fix the following warning:
> capability_linux.go:407:17: S1039: unnecessary use of fmt.Sprintf (gosimple)
> status_path = fmt.Sprintf("/proc/self/status")
> ^
Also,
- simplify the code for the common case when pid is 0;
- rename a variable (to obey Go naming guidelines).
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Fix the following linter warning: > capability_linux.go:34:8: Error return value is not checked (errcheck) > capget(&hdr, nil) > ^ Here we deliberately ignore the error from capget() since we have no way to report it, and hdr.ver will be 0 in case of an error anyway. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
force-pushed
the
linter-warnings
branch
from
ef310fc to
39afd3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few very simple linter warning fixes.
(Originally opened as syndtr#25).