Merge pull request #6 from kolomied/issue/4_update

Switch to SqlServerConnectionStringBuilder to handle complex passwords
kolomied · Jul 27, 2020 · f211545 · f211545
2 parents 4e24140 + 30ca8c5
commit f211545
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/lambda/seed.ps1 b/lambda/seed.ps1
@@ -77,9 +77,14 @@ function RunSQLScript {
         # Retrieving database connection details
         $secret = (Get-SECSecretValue -SecretId $secretArn -Select "SecretString" -ErrorAction Stop) | ConvertFrom-Json
         Write-Host "Database secret retrieved"
-        $username = $secret.username
-        $password = $secret.password
-        $connectionString = "Server=${dbEndpoint};User Id=${username};Password='${password}'"
+
+        $connectionBuilder = New-Object System.Data.SqlClient.SqlConnectionStringBuilder `
+            -Property @{
+                DataSource = $dbEndpoint
+                UserID = $secret.username
+                Password = $secret.password
+            }
+        $connectionString = $connectionBuilder.PSBase.ConnectionString
 
         # execute the cript
         $errorAction = if ($IgnoreErrors) {"Continue"} else {"Stop"}

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "cdk-sqlserver-seeder",
-  "version": "0.2.2",
+  "version": "0.2.3",
   "description": "A simple CDK seeder for SQL Server RDS databases.",
   "scripts": {
     "build": "jsii",