-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added airport table, added cased to data flatten to handle []map[string]interface{} #814
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks expectedly hairy. Nice. Let's walk through it tomorrow?
…, added tests for multiple options with queries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't quite wrapped my head around the tests. Generally, I think the end-to-end tests are good, but in this case, there's enough complexity in the string parsers I'd want unit tests for those.
It's an interesting general question -- a lot of our tables use the general exec-parse-return data pattern, I suspect we want some coherent test approach.
…port data instead of returning error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd take this as is, though there are some test nits if you wanted to loop back to them
[]map[string]interface{}
example outputs: