Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "feat: add special datatype for timestamp (#730)" #732

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Revert "feat: add special datatype for timestamp (#730)" #732

merged 1 commit into from
Dec 17, 2024

Conversation

nankolena
Copy link
Contributor

This reverts commit d4504d2.

Linked issue(s)

Towards KOL-3547

What change does this PR introduce and why?

Reverts #730 until the platform changes are merged

Please check if the PR fulfills these requirements

  • Include reference to internal ticket and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Relevant tests for the changes have been added
  • Relevant docs have been added / updated

@nankolena nankolena requested a review from a team as a code owner December 17, 2024 19:38
@nankolena nankolena enabled auto-merge (squash) December 17, 2024 19:55
@nankolena nankolena merged commit 5e3863c into trunk Dec 17, 2024
57 checks passed
@nankolena nankolena deleted the nan/kol-3547-sdk-revert branch December 17, 2024 20:03
nankolena added a commit that referenced this pull request Dec 17, 2024
@nankolena
Revert "Revert "feat: add special datatype for timestamp (#730)" (#732)"
497b4ab 
This reverts commit 5e3863c.
munkyshi pushed a commit that referenced this pull request Jan 7, 2025
@nankolena
chore: add back special datatype for timestamp (#733)
3c8fb7e 
* Revert "Revert "feat: add special datatype for timestamp (#730)" (#732)"

This reverts commit 5e3863c.

* support iso format by default, refactor tz localization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yifanwu-kolena yifanwu-kolena yifanwu-kolena approved these changes

@munkyshi munkyshi Awaiting requested review from munkyshi

@millerpeterson millerpeterson Awaiting requested review from millerpeterson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nankolena @yifanwu-kolena