Migrate to uv for package management #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
munkyshi
force-pushed
the
andrew/kol-7307-fix-example-test-failure-due-to-slow-dependency-resolution
branch
from
4b9d48e to
46516af
Compare
munkyshi
force-pushed
the
andrew/kol-7307-fix-example-test-failure-due-to-slow-dependency-resolution
branch
from
46516af to
eec9459
Compare
|
Nice! Glad to see the build is working again |
grant-Kolena
approved these changes
Sep 17, 2024
munkyshi
changed the title
Comment on lines
76
to
78
| ```shell | ||
| poetry config http-basic.kolena-embeddings <KOLENA_TOKEN> "" | ||
| uv add --extra-index-url="https://<KOLENA_TOKEN>@gateway.kolena.cloud/repositories" kolena-embeddings | ||
| ``` |
There was a problem hiding this comment.
just want to verify that we tested this manually already
There was a problem hiding this comment.
Yep, I ran this manually and was able to install kolena-embeddings
3 tasks
munkyshi
deleted the
andrew/kol-7307-fix-example-test-failure-due-to-slow-dependency-resolution
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issue(s)
KOL-7307
What change does this PR introduce and why?
Replace
poetrywithuvfor dependency management and tooling.Installing
kolenais potentially a long process, and the dependency resolution time withpoetryhas crept up to the point of causing our workflow tests to flake.uvseems to offer a much faster interface for this, while preserving simplicity of development.Also removes codecov for now, as it's something that hasn't been actively used / monitored.
Please check if the PR fulfills these requirements