make: replicate ci workflow into a makefile #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to help local development. As of now, default behaviour is to git push to origin -- as default remote -- from current branch.
|
I think this would be better as scripts in package.json since we're already using that. I don't what the others think. |
|
On Tue Oct 15, 2024 at 3:18 AM UTC, Alexander Goussas wrote:
I think this would be better as scripts in package.json since we're already using that. I don't what the others think.
My bad. README.md points to `pnpm` for development purposes; so, I used that.
I can modify Makefile to use npm -- no problem! --, or, to get a variable that points to use to either npm or pnpm, whatever is best for the repo.
Just tell me!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to help local development.
As of now, default behaviour is to git push to origin -- as default remote -- from current branch.
According to documentation, you can use a makefile with Github Actions. That would be a good follow up PR.
P.S. Also added a target to format files before push. It's possible this should be in .git/hooks; but, it's here!