AnonymousSpace #1321
Merged
AnonymousSpace #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memory space which is accessible to and from all others [kokkos#1175]
|
don't merge, got some failures with more testing... |
|
Okay, fixed the dependence on |
crtrott
requested changes
Jan 5, 2018
core/src/Kokkos_AnonymousSpace.hpp
Outdated
|
|
||
| template<typename OtherSpace> | ||
| struct MemorySpaceAccess< Kokkos::AnonymousSpace , OtherSpace > { | ||
| enum { assignable = false }; |
There was a problem hiding this comment.
This needs to be true, and also we need to test this. Assigning any memory space view to anonymous view should be possible.
There was a problem hiding this comment.
Yeah I was kinda wondering; that's the whole idea right?
| enum { accessible = true }; | ||
| enum { deepcopy = true }; | ||
| }; | ||
|
|
There was a problem hiding this comment.
Do we need to add VerifyExecutionCanAccessMemorySpace ???
There was a problem hiding this comment.
This is strange, but I can't actually find any use in Kokkos core of VerifyExecutionCanAccessMemorySpace, even indirectly through a macro. Only the new ScatterView uses it. Everything else including View::operator() safety check uses MemorySpaceAccess.
There was a problem hiding this comment.
Tpetra still uses it a lot though, so I'll add it.
|
Only spot check failures are due to module issues |
|
I came up with a workaround for the missing module and threw that into this PR as well. Spot checks now all pass: |
crtrott
approved these changes
Jan 5, 2018
|
As soon as it actually doesn't segfault our nightlies on some machines .... |
|
@crtrott weird :( |
|
see possible fix in #1328 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
memory space which is accessible
to and from all others,
also includes a unit test
[#1175]