Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated Makefile.kokkos does not include KOKKOS_INTERNAL_USE_SERIAL definition #1418

Closed
ndellingwood opened this issue Feb 16, 2018 · 1 comment
Closed

Generated Makefile.kokkos does not include KOKKOS_INTERNAL_USE_SERIAL definition #1418

ndellingwood opened this issue Feb 16, 2018 · 1 comment
Assignees
@ndellingwood
Milestone
2018 February

Comments

@ndellingwood
Copy link
Contributor

A couple lines needed to propogate definition of KOKKOS_INTERNAL_USE_SERIAL to generated Makefile.kokkos are missing from core/src/Makefile.generate_build_files
e.g. @$(call kokkos_append_var,KOKKOS_INTERNAL_USE_SERIAL,'STRING ""')

Found this issue while trying to build Serial unit tests in kokkos-kernels, reported there in issue # 154

PR coming right up...
@ndellingwood ndellingwood added the Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) label Feb 16, 2018
@ndellingwood ndellingwood added this to the 2018 February milestone Feb 16, 2018
@ndellingwood ndellingwood self-assigned this Feb 16, 2018
ndellingwood added a commit to ndellingwood/kokkos that referenced this issue Feb 16, 2018
@ndellingwood
Makefile.generate_build_files: missing Serial defintion
a1635e4 
Add missing lines for definition of KOKKOS_INTERNAL_USE_SERIAL
Addresses issue kokkos#1418 and kokkos-kernels issue # 154
@ndellingwood ndellingwood mentioned this issue Feb 16, 2018
Merged
@ndellingwood
Copy link
Contributor Author

PR #1419 addresses this issue.

@ndellingwood ndellingwood mentioned this issue Feb 16, 2018
Closed
@ibaned ibaned added bug - fix pushed to develop branch and removed Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) labels Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndellingwood ndellingwood

Labels
None yet
Projects
None yet
Milestone
2018 February
Development

No branches or pull requests
2 participants
@ibaned @ndellingwood