Added code to allow KokkosKernels coloring to accept partial colorings #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
brian-kelley
approved these changes
Apr 28, 2021
There was a problem hiding this comment.
@ibogle The code looks good. Would you have time to add tests for d1/d2 recoloring? I'm thinking:
- just copy an existing coloring test
- color
- uncolor some vertices at random
- recolor
- test for valid coloring
If you don't have time, it's ok to just merge I think.
|
Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ brian-kelley ]! |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: KokkosKernels_PullRequest_GCC720
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_GCC720
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_INTEL18
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC720_Light
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_CUDA10
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_CUDA9
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_GCC720_GCC740
Jenkins Parameters
Using Repos:
Pull Request Author: ibogle |
|
@brian-kelley I'll look into that, I don't think it would take too long to put some tests together. |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: KokkosKernels_PullRequest_GCC720
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_GCC720
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_INTEL18
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC720_Light
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_CUDA10
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_CUDA9
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_GCC720_GCC740
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ brian-kelley ]! |
|
Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge |
2 similar comments
|
Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge |
|
Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge |
|
@brian-kelley It doesn't look like I'll have time to get those tests together after all, sorry! |
|
@ibogle That's OK. I can try doing that next week. |
|
Cherry-picked to release-candidate-3.4.1 directly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These code changes allow KokkosKernels' coloring routines to accept partial colorings and prevent any previously-colored vertex from being recolored. These changes do not significantly impact the existing interface or performance of the coloring code, to my knowledge. Zoltan2's distributed coloring depends on these changes.
~/fork.kokkos-kernels-coloring/scripts/cm_test_all_sandia --kokkoskernels-path=/ascldap/users/ibogle/fork.kokkos-kernels-coloring/ --kokkos-path=/ascldap/users/ibogle/kokkos --arch=Power8,Kepler80 cuda/10.1.105 --spot-check
Running on machine: white
WARNING!! THE FOLLOWING CHANGES ARE UNCOMMITTED!! :
M src/graph/KokkosGraph_Distance1Color.hpp
M src/graph/KokkosGraph_Distance1ColorHandle.hpp
M src/graph/KokkosGraph_Distance2ColorHandle.hpp
M src/graph/impl/KokkosGraph_Distance1Color_impl.hpp
M src/graph/impl/KokkosGraph_Distance2Color_impl.hpp
?? testing/
KokkosKernels Repository Status: 5016b18 Merge pull request #936 from ndellingwood/fix-cplx-arithtraits
Kokkos Repository Status: f654c0c5da3dc40f568394f50f9a87893d333691 Merge pull request #3928 from masterleinad/sycl_fix_profiling_deallocate_data
Going to test compilers: cuda/10.1.105
Testing compiler cuda/10.1.105
Unrecognized compiler cuda/10.1.105 when looking for Spack variants
Unrecognized compiler cuda/10.1.105 when looking for Spack variants
Unrecognized compiler cuda/10.1.105 when looking for Spack variants
Starting job cuda-10.1.105-Cuda_OpenMP-release
kokkos devices: Cuda,OpenMP
kokkos arch: Power8,Kepler80
kokkos options:
kokkos cuda options:
kokkos cxxflags: -O3 -Wall -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wuninitialized
extra_args:
kokkoskernels scalars: 'double,complex_double'
kokkoskernels ordinals: int
kokkoskernels offsets: int,size_t
kokkoskernels layouts: LayoutLeft
PASSED cuda-10.1.105-Cuda_OpenMP-release
Unrecognized compiler cuda/10.1.105 when looking for Spack variants
Unrecognized compiler cuda/10.1.105 when looking for Spack variants
Unrecognized compiler cuda/10.1.105 when looking for Spack variants
Starting job cuda-10.1.105-Cuda_Serial-release
kokkos devices: Cuda,Serial
kokkos arch: Power8,Kepler80
kokkos options:
kokkos cuda options:
kokkos cxxflags: -O3 -Wall -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wuninitialized
extra_args:
kokkoskernels scalars: 'double,complex_double'
kokkoskernels ordinals: int
kokkoskernels offsets: int,size_t
kokkoskernels layouts: LayoutLeft
PASSED cuda-10.1.105-Cuda_Serial-release
#######################################################
PASSED TESTS
#######################################################
cuda-10.1.105-Cuda_OpenMP-release build_time=723 run_time=166
cuda-10.1.105-Cuda_Serial-release build_time=688 run_time=216