Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing seg fault with empty matrix in kspiluk #871

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

vqd8a
Copy link
Contributor

@vqd8a vqd8a commented Jan 7, 2021

PR matching changes to kokkos-kernels needed for trilinos/Trilinos#8547

@vqd8a vqd8a changed the title Fixing seg fault with empty matrix Fixing seg fault with empty matrix in kspiluk Jan 7, 2021
@vqd8a vqd8a requested a review from ndellingwood January 7, 2021 05:06
@vqd8a vqd8a self-assigned this Jan 7, 2021
@vqd8a vqd8a added the bug label Jan 7, 2021
Copy link
Contributor

@ndellingwood ndellingwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for commenting the need for the update

@vqd8a
Copy link
Contributor Author

vqd8a commented Jan 8, 2021

I ran spot-check on kokkos-dev-2. All builds and tests passed, except for intel/17.0.1. It looks like this is a license issue (see the attached log file). Is this a known issue?
intel-17.0.1-Serial-release.configure.log

Spot-check results:

   ../kokkos-kernels/scripts/cm_test_all_sandia --kokkos-path=/ascldap/users/vqdang/Kokkos/kokkos --spot-check

Running on machine: kokkos-dev-2

KokkosKernels Repository Status:  94761a00d7805d8bf12efadc39d6761d697795c7 Fixing seg fault with empty matrix

Kokkos Repository Status:  7f76f68a78c20d043cd8f6dd23bdbfdb3ccd0091 Merge pull request #3713 from keichi/add-ampere-86

Going to test compilers:  gcc/7.3.0 gcc/8.3.0 gcc/9.1 intel/17.0.1 intel/18.0.5 intel/19.0.5 clang/8.0 clang/9.0.0 cuda/10.1 cuda/9.2 cuda/11.0

#######################################################
PASSED TESTS
#######################################################
clang-8.0-Cuda_OpenMP-release build_time=725 run_time=141
clang-8.0-Pthread_Serial-release build_time=241 run_time=131
clang-9.0.0-Pthread-release build_time=155 run_time=61
clang-9.0.0-Serial-release build_time=163 run_time=50
cuda-10.1-Cuda_OpenMP-release build_time=903 run_time=142
cuda-11.0-Cuda_OpenMP-release build_time=937 run_time=144
cuda-9.2-Cuda_Serial-release build_time=889 run_time=230
gcc-7.3.0-OpenMP-release build_time=173 run_time=47
gcc-7.3.0-Pthread-release build_time=135 run_time=62
gcc-8.3.0-Serial-release build_time=170 run_time=53
gcc-9.1-OpenMP-release build_time=213 run_time=46
gcc-9.1-Serial-release build_time=197 run_time=51
intel-18.0.5-OpenMP-release build_time=678 run_time=49
intel-19.0.5-Pthread-release build_time=343 run_time=57
#######################################################
FAILED TESTS
#######################################################
intel-17.0.1-Serial-release (build failed)
#######################################################

@vqd8a
Copy link
Contributor Author

vqd8a commented Jan 12, 2021

@ndellingwood could you please merge this? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants