-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fallback condition to use spmv_native when cuSPARSE won't work #834
Conversation
brian-kelley
commented
Oct 16, 2020
- Improve SpMV unit test:
- generate random complex values with nonzero imaginary component
- catch exceptions in spmv
- Add "spmv_native" support to the cusparse spmv file (this calls KokkosKernels spmv)
- Fall back to native for mode 'C' (which cusparse doesn't have), or modes 'T'/'H' for CUDA 9 (fixing cuda.sparse_spmv test failure on Kepler arch with cusparse in Trilinos nightly build #833)
- Fix some minor type casts/checks in spgemm/sptrsv cusparse wrappers - now those builds and tests succeed with all 4 possible combinations of offset/ordinal width
Improve SpMV unit test: - generate random complex values with nonzero imaginary component - catch exceptions in spmv
Kokkos-dev2, non-TPL: TPL: RIDE, non-TPL: TPL: Only failures on RIDE were due to #799 (cuda.batched_scalar_teamvector_solve_utv2_double) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me, thanks @brian-kelley !