Wiki examples: tests added #737

lucbv · 2020-06-05T13:42:55Z

@srajama1 @ndellingwood @jjwilke
Adding a couple of tests to make sure that the examples in the wiki are actually compiling and working correctly.
This includes two new test: wiki_crsmatrix and wiki_spmv as well as some CMake logic to get things compiled and tested.

See issue #735 for additional information.

lucbv · 2020-06-05T13:45:23Z

Sorry for opening a second PR, the previous one was using my develop branch which I keep in sync with this repo to avoid conflict, etc... this new PR actually uses a feature branch.
This shall teach me that no PR opened at 2am is worth the trouble...

srajama1 · 2020-06-05T15:30:51Z

@lucbv : Can we add these to the tutorials directory as well ?

lucbv · 2020-06-05T16:51:43Z

@srajama1 sure, I did not realize we had a tutorial directory and I cannot find it in our source code, is it in a different repo?

srajama1 · 2020-06-05T18:27:22Z

It is with Kokkos Tutorial
https://github.com/kokkos/kokkos-tutorials

crtrott · 2020-06-05T18:28:42Z

If you want to add them to the turoial someone needs to write the slides for that.

jjwilke · 2020-06-05T21:54:20Z

CMakeLists.txt

@@ -78,6 +78,7 @@ IF (KokkosKernels_INSTALL_TESTING)
  KOKKOSKERNELS_ADD_TEST_DIRECTORIES(test_common)
  KOKKOSKERNELS_ADD_TEST_DIRECTORIES(perf_test)
  KOKKOSKERNELS_ADD_TEST_DIRECTORIES(unit_test)
+  KOKKOSKERNELS_ADD_EXAMPLE_DIRECTORIES(example)


When doing install testing we force testing on. Does it make sense to do the same for examples?

SET(KOKKOSKERNELS_ENABLE_EXAMPLES ON)

jjwilke · 2020-06-05T21:55:11Z

example/wiki/sparse/KokkosSparse_wiki_crsmatrix.cpp

+    graph_type myGraph(entries, row_map);
+    matrix_type myMatrix("test matrix", numRows, values, myGraph);
+  }
+


The examples don't print anything at the end. Is there some performance stat or some sort of message that makes sense to print so the user knows the test is running successfully?

It's a fair question, at the moment if an error happens during construction the test will fail, if it reaches completion is will return 0 which ctest interprets as success.
I can add screen output that states that the matrix constructor has been called successfully, I could do the same for the graph constructor actually.

jjwilke · 2020-06-05T21:56:36Z

CMakeLists.txt

@@ -188,7 +189,7 @@ ELSE()
  KOKKOSKERNELS_ADD_TEST_DIRECTORIES(test_common)
  KOKKOSKERNELS_ADD_TEST_DIRECTORIES(perf_test)
  KOKKOSKERNELS_ADD_TEST_DIRECTORIES(unit_test)
-  #KOKKOSKERNELS_ADD_EXAMPLE_DIRECTORIES(example)
+  KOKKOSKERNELS_ADD_EXAMPLE_DIRECTORIES(example)


I would squash the two commits.

I figured I would get comments on the CMake side at least so I felt like squashing was going to be an inevitability before the PR merges ; )

jjwilke

Spot check passes for me. Approve after squashing.

A couple of unrelated lines got changed (trailing spaces cleaned up). Not sure what we want the policy to be on this going forward?

lucbv · 2020-06-07T22:02:27Z

@jjwilke the comment on whitespaces reminds me that I should probably run clang formatting on the two new examples. I am guilty of not doing it since I have not looked into integrating clang-format with emacs. I am guessing that there must be a script out there that modifies the formatting policy in emacs to use the local project clang format file?

The added tests are fairly small and simple so it should be no problem to have them built and tested. Also adding CMake logic to actually enable the tests. Reformatting both example using clang-format

lucbv · 2020-06-08T21:51:45Z

kokkos-dev: spot_check

#######################################################
PASSED TESTS
#######################################################
clang-4.0.1-Pthread_Serial-release build_time=318 run_time=126
clang-7.0.1-Cuda_OpenMP-release build_time=1078 run_time=543
cuda-9.2-Cuda_OpenMP-release build_time=1677 run_time=571
gcc-5.3.0-OpenMP-release build_time=213 run_time=62
gcc-7.3.0-Serial-release build_time=188 run_time=67
intel-16.0.3-Pthread-release build_time=289 run_time=66
intel-16.0.3-Serial-release build_time=297 run_time=75
intel-17.0.1-OpenMP-release build_time=427 run_time=54

kokkos-dev: spot_check_tpls

#######################################################
PASSED TESTS
#######################################################
clang-4.0.1-Pthread_Serial-release build_time=315 run_time=129
clang-7.0.1-Cuda_OpenMP-release build_time=1084 run_time=263
cuda-9.2-Cuda_OpenMP-release build_time=1150 run_time=297
gcc-5.3.0-OpenMP-release build_time=216 run_time=64
gcc-7.3.0-Serial-release build_time=186 run_time=67
intel-16.0.3-Pthread-release build_time=283 run_time=65
intel-16.0.3-Serial-release build_time=300 run_time=74
intel-17.0.1-OpenMP-release build_time=424 run_time=52

lucbv · 2020-06-08T22:07:12Z

@ndellingwood if that's OK with you it seems that this can be merged.
Work on incorporating some of this into the kokkos-kernels tutorial will need to go into another PR against the appropriate repo.

lucbv · 2020-06-09T20:01:27Z

@srajama1 @brian-kelley
If one of you feels like clicking the merge button that would be nice : )
I am working on more of these examples for another PR and it would be nice to have the CMake changes in develop.

lucbv added enhancement Documentation labels Jun 5, 2020

lucbv requested review from jjwilke, brian-kelley and ndellingwood June 5, 2020 13:42

lucbv self-assigned this Jun 5, 2020

lucbv mentioned this pull request Jun 5, 2020

Wiki examples: tests added #736

Closed

lucbv force-pushed the wiki_examples branch from 211c567 to 279bbf3 Compare June 5, 2020 20:50

jjwilke suggested changes Jun 5, 2020

View reviewed changes

jjwilke reviewed Jun 5, 2020

View reviewed changes

jjwilke approved these changes Jun 7, 2020

View reviewed changes

lucbv force-pushed the wiki_examples branch from 45e7ceb to c0d98fb Compare June 7, 2020 22:53

Adding examples from the wiki and CMake logic to build and test them

c0d98fb

The added tests are fairly small and simple so it should be no problem to have them built and tested. Also adding CMake logic to actually enable the tests. Reformatting both example using clang-format

brian-kelley approved these changes Jun 8, 2020

View reviewed changes

srajama1 merged commit e8fa59e into kokkos:develop Jun 10, 2020

lucbv deleted the wiki_examples branch August 31, 2022 21:18

dalg24 mentioned this pull request Jan 25, 2023

Drop "fenl" example #1655

Closed

kokkos-devops-admin mentioned this pull request Jul 15, 2023

Improve BSR matrix SpMV Performance #1740

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wiki examples: tests added #737

Wiki examples: tests added #737

lucbv commented Jun 5, 2020

lucbv commented Jun 5, 2020

srajama1 commented Jun 5, 2020

lucbv commented Jun 5, 2020

srajama1 commented Jun 5, 2020

crtrott commented Jun 5, 2020

jjwilke Jun 5, 2020

jjwilke Jun 5, 2020

lucbv Jun 6, 2020

jjwilke Jun 5, 2020

lucbv Jun 6, 2020

jjwilke left a comment

lucbv commented Jun 7, 2020

lucbv commented Jun 8, 2020

lucbv commented Jun 8, 2020

lucbv commented Jun 9, 2020

Wiki examples: tests added #737

Wiki examples: tests added #737

Conversation

lucbv commented Jun 5, 2020

lucbv commented Jun 5, 2020

srajama1 commented Jun 5, 2020

lucbv commented Jun 5, 2020

srajama1 commented Jun 5, 2020

crtrott commented Jun 5, 2020

jjwilke Jun 5, 2020

Choose a reason for hiding this comment

jjwilke Jun 5, 2020

Choose a reason for hiding this comment

lucbv Jun 6, 2020

Choose a reason for hiding this comment

jjwilke Jun 5, 2020

Choose a reason for hiding this comment

lucbv Jun 6, 2020

Choose a reason for hiding this comment

jjwilke left a comment

Choose a reason for hiding this comment

lucbv commented Jun 7, 2020

lucbv commented Jun 8, 2020

kokkos-dev: spot_check

kokkos-dev: spot_check_tpls

lucbv commented Jun 8, 2020

lucbv commented Jun 9, 2020